Skip to content

fix: Coinbase Wallet connection on same chain #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: Coinbase Wallet connection on same chain #5656

merged 1 commit into from
Dec 9, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 9, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on fixing the connection issue with the cb wallet browser extension by ensuring the correct chain is switched when connecting.

Detailed summary

  • Updated the condition in coinbase-web.ts to check chainId instead of connectedChainId for switching chains.
  • Ensured the chain switch occurs only when chainId and options?.chain are provided and they differ.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:14am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:14am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:14am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:14am

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 463867a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 9, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Dec 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 9, 2024 09:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.13 KB (0%) 823 ms (0%) 182 ms (+91.21% 🔺) 1.1 s
thirdweb (cjs) 104.48 KB (0%) 2.1 s (0%) 298 ms (+23.66% 🔺) 2.4 s
thirdweb (minimal + tree-shaking) 4.37 KB (0%) 88 ms (0%) 10 ms (-15.31% 🔽) 97 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (-74.44% 🔽) 24 ms
thirdweb/react (minimal + tree-shaking) 16.99 KB (0%) 340 ms (0%) 105 ms (+81.05% 🔺) 445 ms

@codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.61%. Comparing base (015293e) to head (463867a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5656      +/-   ##
==========================================
- Coverage   50.63%   50.61%   -0.03%     
==========================================
  Files        1091     1091              
  Lines       57100    57096       -4     
  Branches     4589     4586       -3     
==========================================
- Hits        28914    28900      -14     
- Misses      27470    27482      +12     
+ Partials      716      714       -2
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 015293e
packages 47.06% <0.00%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 29.87% <0.00%> (-0.26%) ⬇️

... and 5 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit f680496 into main Dec 9, 2024
30 of 33 checks passed
@joaquim-verges joaquim-verges deleted the fix_Coinbase_Wallet_connection_on_same_chain branch December 9, 2024 09:17
@jnsdls jnsdls mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges